[PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver

[Kumar Gala]

On Jan 21, 2014, at 5:01 PM, Andy Gross <agross at codeaurora.org> wrote:

> On Tue, Jan 21, 2014 at 09:03:43AM +0100, Arnd Bergmann wrote:
>> On Monday 20 January 2014 16:52:45 Andy Gross wrote:
>> 
>>>>> +#ifdef CONFIG_OF
>>>>> +static const struct of_device_id bam_of_match[] = {
>>>>> +	{ .compatible = "qcom,bam-v1.4.0", },
>>>>> +	{ .compatible = "qcom,bam-v1.4.1", },
>>>>> +	{}
>>>>> +};
>>>>> +MODULE_DEVICE_TABLE(of, bam_of_match);
>>>>> +#endif
>>>> 
>>>> Also, you can remove the #ifdef here and the of_match_ptr() below.
>>>> 
>>> 
>>> If this is removed, then I'll have to add the OF dependency in the Kconfig,
>>> correct?
>> 
>> I believe it will still compile without the CONFIG_OF dependency, but
>> having the dependency still makes sense as it's impossible to use the
>> driver without CONFIG_OF.
>> 
>> The best dependency line is probably
>> 
>> 	depends on (ARCH_MSM && OF) || COMPILE_TEST"
>> 
>> If you expect the same driver to be used on non-MSM platforms from
>> qualcomm, e.g. some networking or server equipment, you can also just
>> drop the ARCH_MSM dependency.
> 
> 
> Thanks for the clarification.  I think I'll probably do:
> ARCH_MSM_DT || (COMPILE_TEST && ARM)

Didn’t you need it to be:

ARCH_MSM_DT || (COMPILE_TEST && OF && ARM)

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation