[PATCH 1/6] arm64: Add macros to manage processor debug state

[Will Deacon]

On Thu, Jan 23, 2014 at 04:46:36AM +0000, Vijay Kilari wrote:
> On Wed, Jan 22, 2014 at 11:01 PM, Will Deacon <will.deacon at arm.com> wrote:
> >> diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c
> >> index 23586bd..774ad04 100644
> >> --- a/arch/arm64/kernel/debug-monitors.c
> >> +++ b/arch/arm64/kernel/debug-monitors.c
> >> @@ -51,7 +51,7 @@ u8 debug_monitors_arch(void)
> >>  static void mdscr_write(u32 mdscr)
> >>  {
> >>       unsigned long flags;
> >> -     local_dbg_save(flags);
> >> +     flags = local_dbg_save();
> >
> > Why are you changing the API? This is now pointlessly different to irqs.
> 
> To be in line with arch_local_irq_save & arch_local_save_flags in irqflags.h,
> I moved this macros into functions and accordingly changed the caller.
> I could not find any code using this local_dbg_{save, restore} except
> from debug-monitors.c file
> 
> If required, I can think of renaming local_dbg_{save,restore} as
> local_dbg_{save,restore}_flags

No, I'd rather local_dbg_{save, restore} were aligned with local_irq_{save,
restore} (as defined in include/linux/irqflags.h).

Will