[PATCH] ARM: asm: __und_usr_thumb need byteswap instructions in BE case

Victor Kamensky victor.kamensky at linaro.org
Tue Jan 21 00:49:16 EST 2014


On 20 January 2014 17:56, Stephen Boyd <sboyd at codeaurora.org> wrote:
> On 01/14/14 01:05, Dave Martin wrote:
>> On Mon, Jan 13, 2014 at 02:30:51PM -0800, Victor Kamensky wrote:
>>> __und_usr_thumb function deals with thumb2 opcodes. In case of BE
>>> image, it needs to byteswap half word thumb2 encoded instructions
>>> before further processing them.
>>>
>>> Without this fix BE image user-land thread executing first VFP
>>> instruction encoded in thumb2 fails with SIGILL, because kernel
>>> does not recognize instruction and does not enable VFP.
>>>
>>> Reported-by: Corey Melton <comelton at cisco.com>
>>> Signed-off-by: Victor Kamensky <victor.kamensky at linaro.org>
>> Good spot.  This looks like the correct fix to me.
>>
>> Acked-by: Dave Martin <Dave.Martin at arm.com>
>>
>
> Can you please send this to the patch tracker? Feel free to add
>
> Tested-by: Stephen Boyd <sboyd at codeaurora.org>

Thanks. It is done on both counts. Patch is submitted as [1].

Thanks,
Victor

[1] http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7946/1

> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation
>



More information about the linux-arm-kernel mailing list