[PATCH 5/5] clk: versatile: respect parent rate in ICST clock

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Jan 20 16:33:27 EST 2014


On Mon, Jan 20, 2014 at 10:16:53PM +0100, Linus Walleij wrote:
> On Mon, Jan 20, 2014 at 10:12 PM, Russell King - ARM Linux
> <linux at arm.linux.org.uk> wrote:
> 
> >> -static const struct icst_params impd1_vco2_params = {
> >> +static struct icst_params impd1_vco2_params = {
> >>       .ref            = 24000000,     /* 24 MHz */
> >>       .vco_max        = ICST525_VCO_MAX_3V,
> >>       .vco_min        = ICST525_VCO_MIN,
> >
> > Right, so we end up writing directly into these _shared_ _statically_
> > _allocated_ structures.
> 
> Argh yeah that's right.
> 
> I'll think of something better, like allocating the params on-the-fly
> for DT instead.

That's actually why they're const - they're const because they are not
supposed to be written to...

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".



More information about the linux-arm-kernel mailing list