[PATCH] dma: fix vchan_cookie_complete() debug print
Vinod Koul
vinod.koul at intel.com
Mon Jan 20 07:03:01 EST 2014
On Mon, Jan 20, 2014 at 11:28:22AM +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 20, 2014 at 03:29:17PM +0530, Vinod Koul wrote:
> > On Fri, Dec 06, 2013 at 04:42:09PM +0100, Jonas Jensen wrote:
> > > vd->tx.cookie is set zero on dma_cookie_complete(),
> > > save to local before printing it.
> > >
> > > Signed-off-by: Jonas Jensen <jonas.jensen at gmail.com>
> > > ---
> > >
> > > Notes:
> > > dev_vdbg() could also be moved to happen earlier, what do you prefer?
> > This would be preferred IMHO. Also pls cc dmaengine at vger on this
>
> I prefer this version - it means that the verbose debug printk doesn't
> impact the completion timing when printk is expensive (eg, because its
> outputting via a serial port.)
But if you know your printk is costly, do you want to enable these?
--
~Vinod
More information about the linux-arm-kernel
mailing list