[PATCH] dma: imx-sdma: remove firmare not found warning

Vinod Koul vinod.koul at intel.com
Mon Jan 20 02:42:05 EST 2014


On Thu, Jan 16, 2014 at 04:46:26PM +0100, Sascha Hauer wrote:
> When a firmware cannot be found for the SDMA engine then we can
> continue with the inernal ROM firmware.
typo		    ^^^^^^^

> The meaning of this message is frequently asked for and the usual
> answer is that this message is of no relevance, so just make it
> dev_dbg() and do not alienate the users anymore.
> 
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> Cc: Vinod Koul <vinod.koul at intel.com>
> ---
>  drivers/dma/imx-sdma.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index c75679d..fe57a42 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1259,7 +1259,10 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
>  	unsigned short *ram_code;
>  
>  	if (!fw) {
> -		dev_err(sdma->dev, "firmware not found\n");
> +		dev_dbg(sdma->dev, "firmware not found\n");
Shouldn't this be dev_info and would amke sense, external firmware not found
using internal one??

--
~Vinod
> +		/*
> +		 * In this case we just use the ROM firmware.
> +		 */
>  		return;
>  	}
>  
> -- 
> 1.8.5.2
> 

-- 



More information about the linux-arm-kernel mailing list