[PATCH] ARM: kirkwood: kirkwood_pm_init() should return void

Ezequiel Garcia ezequiel.garcia at free-electrons.com
Sat Jan 18 19:29:53 EST 2014


On Sat, Jan 18, 2014 at 06:54:11PM -0500, Jason Cooper wrote:
> On Fri, Jan 17, 2014 at 03:52:11PM -0300, Ezequiel Garcia wrote:
> > This function was originally meant to return void as declared in the
> > common.h header. Fix it and include the header to catch these errors
> > in the future.
> > 
> > Reported-by: Andrew Lunn <andrew at lunn.ch>
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
> > ---
> >  arch/arm/mach-kirkwood/pm.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> merf.  I get the following warning when building kirkwood_defconfig:
> 
> arch/arm/mach-kirkwood/pm.c: In function 'kirkwood_pm_init':
> arch/arm/mach-kirkwood/pm.c:73:2: warning: 'return' with a value, in function returning void [enabled by default]
> 

Doh...

> I've amended the patch as below and pushed it to mvebu/fixes
> 

Thanks!
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com



More information about the linux-arm-kernel mailing list