[PATCH v3 2/8] clk: sunxi: update clock-output-names dt binding documentation
Emilio López
emilio at elopez.com.ar
Thu Jan 16 21:55:45 EST 2014
Hi,
El 09/01/14 05:52, Chen-Yu Tsai escribió:
> clock-output-names is now required for most of sunxi clock nodes, to
> provide the name of the corresponding clock. Add the new requirements,
> exceptions, as well as examples.
>
> Signed-off-by: Chen-Yu Tsai <wens at csie.org>
> ---
> Documentation/devicetree/bindings/clock/sunxi.txt | 36 +++++++++++++++++++----
> 1 file changed, 31 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/sunxi.txt b/Documentation/devicetree/bindings/clock/sunxi.txt
> index 0c127cd..8a9147d 100644
> --- a/Documentation/devicetree/bindings/clock/sunxi.txt
> +++ b/Documentation/devicetree/bindings/clock/sunxi.txt
> @@ -44,10 +44,18 @@ Required properties for all clocks:
> multiplexed clocks, the list order must match the hardware
> programming order.
> - #clock-cells : from common clock binding; shall be set to 0 except for
> - "allwinner,*-gates-clk" where it shall be set to 1
> + "allwinner,*-gates-clk", "allwinner,sun4i-pll5-clk" and
> + "allwinner,sun4i-pll6-clk" where it shall be set to 1
>
> -Additionally, "allwinner,*-gates-clk" clocks require:
> -- clock-output-names : the corresponding gate names that the clock controls
> +Additionally, most clocks require "clock-output-names":
> +- "allwinner,*-gates-clk" : the corresponding gate names that the clock controls
> +- "allwinner,sun4i-pll5-clk" : "pll5_ddr", "pll5_mbus"
> +- "allwinner,sun4i-pll6-clk" : "pll6_sata", "pll6_other"
> +- "allwinner,sun4i-cpu-clk", "allwinner,sun4i-axi-clk",
> + "allwinner,sun4i-ahb-clk", "allwinner,sun4i-ahb-clk",
> + "allwinner,sun4i-apb1-mux-clk", "allwinner,sun4i-apb1-clk"
> + do not need "clock-output-names"
> +- all others clocks : the corresponding module name of that clock
As we discussed on IRC, I wonder if such verbosity is actually needed.
Maybe we should dictate that all clocks must list their corresponding
outputs on clock-output-names (with it being the module name if it only
has one output).
Cheers,
Emilio
More information about the linux-arm-kernel
mailing list