[PATCH] ARM: S3C[24|64]xx: move includes back under <mach/> scope

Arnd Bergmann arnd at arndb.de
Wed Jan 15 08:19:23 EST 2014


On Wednesday 15 January 2014, Linus Walleij wrote:
> When I look at it, the issue also exist in e.g.
> drivers/gpio/gpio-samsung.c which can be compiled
> (like for allyesconfig) when PLAT_SAMSUNG is set.
> 
> And it is also set to y for ARCH_EXYNOS... which
> doesn't have any custom GPIO header. So this would
> involve something like creating an empty
> <mach/gpio-samsung.h> for Exynos which doesn't
> seem like the right thing to do.

Ah, right. I looked at this before, but I misremembered about
PLAT_SAMSUNG and thought it was fine because ARCH_EXYNOS no
longer implied PLAT_SAMSUNG. That was wrong, instead ARCH_EXYNOS
still sets PLAT_SAMSUNG but not PLAT_S5P as it used to.

> So I'm sticking with the #ifdef patch for now as it
> seems to be the lesser evil :-/

Yes, agreed.

	Arnd



More information about the linux-arm-kernel mailing list