[PATCH -next] clk: exynos-audss: remove redundant dev_err call in exynos_audss_clk_probe()
Jingoo Han
jg1.han at samsung.com
Mon Jan 13 21:18:38 EST 2014
On Tuesday, January 14, 2014 11:06 AM, Wei Yongjun wrote:
>
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
It looks good. This error message is redundant; thus it
should be removed.
Reviewed-by: Jingoo Han <jg1.han at samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/clk/samsung/clk-exynos-audss.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos-audss.c b/drivers/clk/samsung/clk-exynos-audss.c
> index 884187f..01ef381 100644
> --- a/drivers/clk/samsung/clk-exynos-audss.c
> +++ b/drivers/clk/samsung/clk-exynos-audss.c
> @@ -94,10 +94,8 @@ static int exynos_audss_clk_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> reg_base = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(reg_base)) {
> - dev_err(&pdev->dev, "failed to map audss registers\n");
> + if (IS_ERR(reg_base))
> return PTR_ERR(reg_base);
> - }
>
> clk_table = devm_kzalloc(&pdev->dev,
> sizeof(struct clk *) * EXYNOS_AUDSS_MAX_CLKS,
>
> --
More information about the linux-arm-kernel
mailing list