[PATCH 1/4] arm64: topology: Implement basic CPU topology support

Lorenzo Pieralisi lorenzo.pieralisi at arm.com
Mon Jan 13 12:33:20 EST 2014


On Mon, Jan 13, 2014 at 04:44:06PM +0000, Vincent Guittot wrote:

[...]

> >> +extern struct cpu_topology cpu_topology[NR_CPUS];
> >> +
> >> +#define topology_physical_package_id(cpu)    (cpu_topology[cpu].socket_id)
> >> +#define topology_core_id(cpu)                (cpu_topology[cpu].core_id)
> >> +#define topology_core_cpumask(cpu)   (&cpu_topology[cpu].core_sibling)
> >> +#define topology_thread_cpumask(cpu) (&cpu_topology[cpu].thread_sibling)
> >> +
> >> +#define mc_capable() (cpu_topology[0].socket_id != -1)
> >> +#define smt_capable()        (cpu_topology[0].thread_id != -1)
> >
> > Are the two macros above still required in the kernel ? I can't see any
> > usage at present.
> >
> > Vincent, do you know why they were not removed in commit:
> >
> > 8e7fbcbc22c12414bcc9dfdd683637f58fb32759
> >
> > I am certainly missing something.
> 
> I think it was not planned to be used only by the scheduler but since
> 8e7fbcbc22c12414bcc9dfdd683637f58fb32759, we have reach a situation
> where nobody use them for the moment.

Ok, we can add the macros and eventually remove all of them in a later
patch if we think they must go then.

Lorenzo




More information about the linux-arm-kernel mailing list