[PATCH 1/4] arm64: topology: Implement basic CPU topology support

Mark Brown broonie at kernel.org
Mon Jan 13 11:30:45 EST 2014


On Mon, Jan 13, 2014 at 04:10:59PM +0000, Lorenzo Pieralisi wrote:
> On Sun, Jan 12, 2014 at 07:20:38PM +0000, Mark Brown wrote:

> > +struct cpu_topology {
> > +	int thread_id;
> > +	int core_id;
> > +	int socket_id;

> Is there any reason why we can't rename socket_id to cluster_id ? It won't
> change our lives but at least we kind of know what it means in ARM world.

I really don't care, whatever you guys want.

> > +#define mc_capable()	(cpu_topology[0].socket_id != -1)
> > +#define smt_capable()	(cpu_topology[0].thread_id != -1)

> Are the two macros above still required in the kernel ? I can't see any
> usage at present.
> 
> Vincent, do you know why they were not removed in commit:
> 
> 8e7fbcbc22c12414bcc9dfdd683637f58fb32759
> 
> I am certainly missing something.

They're defined by a bunch of other architectures (including x86).  If I
had to guess I'd say the architectures are still providing the
information so we don't need to go round adding it again if someone
comes up with a use for it in the core.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140113/c9185b05/attachment-0001.sig>


More information about the linux-arm-kernel mailing list