[PATCH V2 1/2] mmc: sdhci-esdhc-imx: fix access hardirq-unsafe lock in atomic context

[Dong Aisheng]

Hi Chris,

On Tue, Dec 31, 2013 at 1:24 PM, Shawn Guo <shawn.guo at linaro.org> wrote:
> On Thu, Dec 26, 2013 at 03:23:53PM +0800, Dong Aisheng wrote:
>> Sometimes we may meet the following lockdep issue.
>> The root cause is .set_clock callback is executed with spin_lock_irqsave
>> in sdhci_do_set_ios. However, the IMX set_clock callback will try to access
>> clk_get_rate which is using a mutex lock.
>>
>> The fix avoids access mutex in .set_clock callback by initializing the
>> pltfm_host->clock at probe time and use it later instead of calling
>> clk_get_rate again in atomic context.
>
> <snip>
>
>> Cc: Chris Ball <cjb at laptop.org>
>> Cc: Fabio Estevam <fabio.estevam at freescale.com>
>> Cc: Shawn Guo <shawn.guo at linaro.org>
>
> For both,
>
> Acked-by: Shawn Guo <shawn.guo at linaro.org>
>
>> Fixes: 0ddf03c mmc: esdhc-imx: parse max-frequency from devicetree
>> Signed-off-by: Dong Aisheng <b29396 at freescale.com>
>
>

Can we make patch 1 go into 3.13 final since the issue exists
since 3.13 rc1.

Patch 2 in that series is the fix for sdhci-esdhc-imx runtime pm which is
newly added in chris/mmc-next and seems target for 3.14.

BTW, pls add:
Tested-by: Philippe De Muyter <phdm at macqel.be>

See:
https://lkml.org/lkml/2014/1/13/77

Regards
Dong Aisheng

> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel