[PATCH v2 2/28] drm/i2c: tda998x: check more I/O errors
Russell King - ARM Linux
linux at arm.linux.org.uk
Sat Jan 11 12:01:51 EST 2014
On Thu, Jan 09, 2014 at 11:57:45AM +0100, Jean-Francois Moine wrote:
>
> Signed-off-by: Jean-Francois Moine <moinejf at free.fr>
This lacks a description detailing why this change is necessary. While
I can see the sense in preventing a subsequent write succeeding after a
failed page register write, we still continue blindly on accessing the
device after a read or write fails. For istance, how many calls to
reg_write() or reg_read() are checked for failure?
That said, the patch does not appear to create any detrimental effects,
so it gets a tested-by but *no* acked-by. Please give it a better
description justifying this change for an acked-by.
Tested-by: Russell King <rmk+kernel at arm.linux.org.uk>
--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
More information about the linux-arm-kernel
mailing list