[PATCH v5 3/4] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs

Wolfram Sang wsa at the-dreams.de
Wed Jan 8 10:28:41 EST 2014


> >> +	{
> >> +		.compatible = "marvell,mv78230-a0-i2c",
> >> +		.data = &mv64xxx_i2c_regs_mv64xxx
> >> +	},
> > 
> > I think a oneliner entry like the entries above is easier to read, but
> > that is very minor...
> 
> By using one line we would break the 80 character rule,
> hat why I did in this way.

This rule is there to keep code readable. If it doesn't help
readability, it may/can/should be broken IMO. It's a mileage, though.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140108/dc7ee46a/attachment.sig>


More information about the linux-arm-kernel mailing list