[PATCH v2 3/3] ARM: sun7i: irqchip: Update the documentation

[Carlo Caione]

On Wed, Jan 8, 2014 at 12:29 PM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Monday 06 January 2014, Carlo Caione wrote:
>> +Allwinner Sunxi NMI Controller
>> +==============================
>> +
>> +Required properties:
>> +
>> +- compatible : should be "allwinner,sun7i-sc-nmi"
>> +- reg : Specifies base physical address and size of the registers.
>> +- interrupt-controller : Identifies the node as an interrupt controller
>> +- #interrupt-cells : Specifies the number of cells needed to encode an
>> +  interrupt source. The value shall be 2.
>
> I think you should list what the two cells are so users know what to
> put in the irq specifier.

Agree, I'll fix in v3

>> +sc-nmi-intc at 01c00030 {
>> +       compatible = "allwinner,sun7i-sc-nmi";
>> +       interrupt-controller;
>> +       #interrupt-cells = <2>;
>> +       reg = <0x01c00030 0x0c>;
>> +       interrupt-parent = <&gic>;
>> +       interrupts = <0 0 1>;
>> +};
>
> Is <0 0 1> the correct representation of the NMI? This question has recently
> come up on IRC and I didn't know the answer at the time.

Why shouldn't it be a correct representation? I think I missed the
discussion on IRC.
Actually I already have a MFD driver using this irqchip without any problems.

Thanks,

--
Carlo Caione