[PATCH v3 net-next 1/3] sh_eth: Add support for r7s72100

[Simon Horman]

On Tue, Jan 07, 2014 at 02:07:55PM -0500, David Miller wrote:
> From: Simon Horman <horms+renesas at verge.net.au>
> Date: Tue,  7 Jan 2014 11:27:13 +0900
> 
> > @@ -318,6 +371,14 @@ static int sh_eth_is_gether(struct sh_eth_private *mdp)
> >  		return 0;
> >  }
> >  
> > +static int sh_eth_is_rz_fast_ether(struct sh_eth_private *mdp)
> > +{
> > +	if (mdp->reg_offset == sh_eth_offset_fast_rz)
> > +		return 1;
> > +	else
> > +		return 0;
> > +}
> 
> Please make this return a boolean and use true/false.

Thanks. I will also refactor the giga_ether version of this
function accordingly.

> 
> > @@ -2061,6 +2155,10 @@ static struct net_device_stats *sh_eth_get_stats(struct net_device *ndev)
> >  {
> >  	struct sh_eth_private *mdp = netdev_priv(ndev);
> >  
> > +	if (sh_eth_is_rz_fast_ether(mdp)) {
> > +		return &ndev->stats;
> > +	}
> 
> Single statement basic blocks do not need curly braces, therefore
> please remove them here.

Will do.