[PATCH] ARM: s3c24xx: fix build error

Heiko Stübner heiko at sntech.de
Tue Jan 7 14:12:42 EST 2014


Am Dienstag, 7. Januar 2014, 19:27:25 schrieb Linus Walleij:
> When enabling device tree on the S3C an additional build
> bug appears in the Osiris DVS board file:
> 
> CC  arch/arm/mach-s3c24xx/mach-osiris-dvs.o
> archh/arm/mach-s3c24xx/mach-osiris-dvs.c:
> In function ‘osiris_dvs_notify’:
> arch/arm/mach-s3c24xx/mach-osiris-dvs.c:77:4:
> error: implicit declaration of function ‘S3C2410_GPB’
> [-Werror=implicit-function-declaration]
>     gpio_set_value(OSIRIS_GPIO_DVS, 1);
>     ^
> 
> Fix this by explicitly including
> <linux/platform_data/gpio-samsung-s3c24xx.h>
> 
> Reported-by: Arnd Bergmann <arnd at arndb.de>
> Cc: Kukjin Kim <kgene.kim at samsung.com>
> Cc: Heiko Stuebner <heiko at sntech.de>
> Cc: Tomasz Figa <tomasz.figa at gmail.com>
> Cc: Sylwester Nawrocki <sylvester.nawrocki at gmail.com>
> Cc: Ben Dooks <ben-linux at fluff.org>
> Cc: linux-samsung-soc at vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
> I have tentatively applied this to the GPIO tree so I
> don't cause build regressions, ACKs are still
> appreciated from the S3C maintainers.

Acked-by: Heiko Stuebner <heiko at sntech.de>



More information about the linux-arm-kernel mailing list