[RFC 01/18] mfd: syscon: Consider platform data a regmap config name
Lee Jones
lee.jones at linaro.org
Mon Jan 6 05:20:04 EST 2014
On Mon, 06 Jan 2014, Lee Jones wrote:
> > Use the device platform data as a regmap config
> > name. This is particularly useful in the regmap
> > debugfs when there is more than one syscon device
> > registered, to distinguish the register blocks.
> >
> > Signed-off-by: Pawel Moll <pawel.moll at arm.com>
> > Cc: Samuel Ortiz <sameo at linux.intel.com>
> > Cc: Lee Jones <lee.jones at linaro.org>
> > ---
> > drivers/mfd/syscon.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> > index 71841f9..ea1770b 100644
> > --- a/drivers/mfd/syscon.c
> > +++ b/drivers/mfd/syscon.c
> > @@ -143,6 +143,7 @@ static int syscon_probe(struct platform_device *pdev)
> > return -ENOMEM;
> >
> > syscon_regmap_config.max_register = res->end - res->start - 3;
> > + syscon_regmap_config.name = dev_get_platdata(&pdev->dev);
> > syscon->regmap = devm_regmap_init_mmio(dev, base,
> > &syscon_regmap_config);
> > if (IS_ERR(syscon->regmap)) {
>
> This smells a bit fishy to me. Can you point me to the piece of code
> or patch where you set the platform_data pointer as a string?
Scrap that, I see it.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
More information about the linux-arm-kernel
mailing list