[PATCH v3] ARM: prima2: move to generic reset controller driver framework

[Barry Song]

2014/1/6 Philipp Zabel <p.zabel at pengutronix.de>:
> Hi Barry,
>
>> -
>> -int sirfsoc_reset_device(struct device *dev)
>> +static int sirfsoc_reset_module(struct reset_controller_dev *rcdev,
>> +                                     unsigned long sw_reset_idx)
>>  {
>> -     u32 reset_bit;
>> +     u32 reset_bit = sw_reset_idx;
>>
>> -     if (of_property_read_u32(dev->of_node, "reset-bit", &reset_bit))
>
> It seems switching to the reset controller framework is an incompatible
> device tree change. I take it this is not an issue because the old
> binding was never documented / is not used in the wild?

yes. old binding was never documented and used before it was moved to
reset controller.

> If so, apart from a few whitespace issues, this looks good to me.

may i take this as an Ack from you?

sorry. i missed two tab issues and will fix in v4.

ERROR: code indent should use tabs where possible
#148: FILE: arch/arm/mach-prima2/common.c:20:
+        sirfsoc_of_rstc_init();$

ERROR: code indent should use tabs where possible
#149: FILE: arch/arm/mach-prima2/common.c:21:
+        of_platform_populate(NULL, of_default_bus_match_table,$

>
> regards
> Philipp
>

-barry