[PATCH] ARM: imx: Explicitly pass the active level of the PHY reset

Shawn Guo shawn.guo at linaro.org
Thu Jan 2 22:22:31 EST 2014

On Fri, Jan 03, 2014 at 12:14:13AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at freescale.com>
> Since commit 7a399e3a2e (fec: Do not assume that PHY reset is active low), we no
> longer assume that the PHY reset is active low.
> Now we need to retrieve this information from the device tree instead.
> Passing '0' as the phy-reset-gpios means 'active high' according to the 
> definition from include/dt-bindings/gpio/gpio.h:
> #define GPIO_ACTIVE_HIGH 0
> #define GPIO_ACTIVE_LOW 1
> , so in order to keep things working as before we need to explicitly pass
> GPIO_ACTIVE_LOW as the flag.

So it sounds like we have a git bisect issue here.

> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
> Shawn,
> This is needed for 3.13 as 7a399e3a2e (fec: Do not assume that PHY reset is 
> active low) already reached mainline.

If this is needed for 3.13, you should generate the patch against the
mainline where the fec change is in place rather than my for-next
branch.  And for those dts files that can only be patched against my
for-next branch, we need another patch.


More information about the linux-arm-kernel mailing list