[PATCH 2/7] Input: pmic8xxx-pwrkey - Migrate to regmap APIs
Mark Brown
broonie at kernel.org
Thu Jan 2 19:50:19 EST 2014
On Thu, Jan 02, 2014 at 11:17:57AM -0800, Dmitry Torokhov wrote:
> On Thu, Jan 02, 2014 at 06:49:59PM +0000, Mark Brown wrote:
> > On Sun, Dec 15, 2013 at 03:33:37AM -0800, Dmitry Torokhov wrote:
> > > > + regmap = dev_get_regmap(pdev->dev.parent, NULL);
> > > > + if (!regmap)
> > > > + return -ENODEV;
> > > And you are leaking memory here...
> > He's not, dev_get_regmap() just gets a pointer to an existing regmap -
> > no reference is taken and nothing is allocated. It's a helper that's
> I was not talking about data returned by dev_get_regmap() but all other
> memory that was allocated before as this was pre devm conversion of the
> driver.
Ah, OK - I thought you meant that as that was the code immediately prior
to your reply. Sorry for the confusion.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140103/7a912409/attachment.sig>
More information about the linux-arm-kernel
mailing list