[PATCH] arm64: Fix SCTLR_EL1 initialisation
catalin.marinas at arm.com
Tue Dec 23 02:55:06 PST 2014
On Wed, Dec 17, 2014 at 05:39:16PM +0000, Will Deacon wrote:
> On Wed, Dec 17, 2014 at 03:50:21PM +0000, Suzuki K. Poulose wrote:
> > From: "Suzuki K. Poulose" <suzuki.poulose at arm.com>
> > We initialise the SCTLR_EL1 value by read-modify-writeback
> > of the desired bits, leaving the other bits (including reserved
> > bits(RESx)) untouched. However, sometimes the boot monitor could
> > leave garbage values in the RESx bits which could have different
> > implications. This patch makes sure that all the bits, including
> > the RESx bits, are set to the proper state, except for the
> > 'endianness' control bits, EE(25) & E0E(24)- which are set early
> > in the el2_setup.
> > Updated the state of the Bit in the comment to RES0 in the
> > comment.
> > Signed-off-by: Suzuki K. Poulose <suzuki.poulose at arm.com>
> > Cc: Will Deacon <will.deacon at arm.com>
> > Cc: Catalin Marinas <catalin.marinas at arm.com>
> > ---
> Looks good to me:
> Acked-by: Will Deacon <will.deacon at arm.com>
> Is this 3.19 material, or simply a cleanup/being cautious?
I'll leave this for the 3.20 merging window.
More information about the linux-arm-kernel