[PATCH] clk: shmobile: Add r8a7793 support

[Yoshihiro Kaneko]

2014-12-10 9:18 GMT+09:00 Simon Horman <horms at verge.net.au>:
> On Tue, Dec 09, 2014 at 09:26:09PM +0900, Yoshihiro Kaneko wrote:
>> Hi Simon-san,
>>
>> 2014-12-09 9:23 GMT+09:00 Simon Horman <horms at verge.net.au>:
>> > On Mon, Dec 08, 2014 at 02:30:14PM +0100, Geert Uytterhoeven wrote:
>> >> Hi Kaneko-san,
>> >>
>> >> On Mon, Dec 8, 2014 at 12:53 PM, Yoshihiro Kaneko <ykaneko0929 at gmail.com> wrote:
>> >> > 2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <geert at linux-m68k.org>:
>> >> >> On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <ykaneko0929 at gmail.com> wrote:
>> >> >>> From: Hisashi Nakamura <hisashi.nakamura.ak at renesas.com>
>> >> >>>
>> >> >>> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.
>> >> >>
>> >> >> Thanks for your patch!
>> >> >>
>> >> >>> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak at renesas.com>
>> >> >>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929 at gmail.com>
>> >> >>
>> >> >> Acked-by: Geert Uytterhoeven <geert+renesas at glider.be>
>> >> >>
>> >> >> Can you please also send a patch to update the binding documentation in
>> >> >> Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?
>> >> >
>> >> > This patch updates Makefile only, not added dtsi for r8a7793.
>> >> > Is the update of the document necessary?
>> >>
>> >> Not at this moment. I was just trying to be proactive ;-)
>> >
>> > Kaneko-san,
>> >
>> > I think that the update to renesas,rcar-gen2-cpg-clocks.txt should be a
>> > one line change. I can prepare a patch if you prefer not to.
>>
>> Yes, I know that the update is very small.
>> But "renesas,r8a7793-cpg-clocks" which will be added to the documentation
>> was not found anywhere in the source tree. For example,
>> "renesas,r8a7794-cpg-clocks"
>> is found in arch/arm/boot/dts/r8a7794.dtsi.
>> Is r8a7793.dtsi not necessary to update the document?
>
> In theory (though not always in practice) bindings should
> be documented before they are used. So unless I misunderstand things,
> yes, I think renesas,rcar-gen2-cpg-clocks.txt should be updated
> even though arch/arm/boot/dts/r8a7794.dtsi is (not yet) updated.

I got it. I can prepare a patch which updates the binding document.