[PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Tue Dec 9 23:46:17 PST 2014
Hello Philipp,
On Tue, Dec 09, 2014 at 05:13:35PM +0100, Philipp Zabel wrote:
> + /* on i.MX6Q, the USBMISC register space is clocked by the IPG clock */
> + if (data->ops != &imx6q_usbmisc_ops) {
> + data->clk = devm_clk_get(&pdev->dev, NULL);
I wonder if it was better/simpler to handle devm_clk_get returning
-ENOENT and assume this means there is no need for a clock in this case.
(I think devm_clk_get prints an error message in this case. That's ugly
when the error is handled just fine.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel
mailing list