[PATCH v3 3/3] ARM: tegra: Add Tegra124 ACTMON support

Tomeu Vizoso tomeu.vizoso at collabora.com
Tue Dec 9 06:13:25 PST 2014


On 12/09/2014 06:33 AM, Alexandre Courbot wrote:
> On Fri, Dec 5, 2014 at 1:14 AM, Tomeu Vizoso <tomeu.vizoso at collabora.com> wrote:
>> Add device node for the ACTMON block to the Tegra124 device tree.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
>>
>> ---
>>
>> v3:     * Address misc. style issues found by Thierry and Alexander
>>         * Added helpers for register i/o
>>         * Further documented the structs
>>         * Enable the ACTMON after the IRQ handler has been installed
>>         * Disable the ACTMON before removing the IRQ handler
>>         * Add governor in a subsys initcall
>>
>> v2:     * Add operating-points property
>> ---
>>  arch/arm/boot/dts/tegra124.dtsi        |  23 +
>>  drivers/devfreq/Kconfig                |   7 +-
>>  drivers/devfreq/Makefile               |   2 +-
>>  drivers/devfreq/tegra-actmon-devfreq.c | 777 +++++++++++++++++++++++++++++++++
>>  drivers/devfreq/tegra-devfreq.c        | 718 ------------------------------
> 
> In patch 2/3 you create tegra-devfreq.c, to apparently move it to
> tegra-actmon-devfreq.c and (seemingly) add somemore lines to it. This
> makes things difficult to review, and I am almost sure this is a
> naming mistake - could you fix this and resend?

Sorry, I squashed the changes into the wrong commit. Have sent v4 fixing
this.

Cheers,

Tomeu




More information about the linux-arm-kernel mailing list