[PATCH 1/4] ARM: shmobile: R-Mobile: Add SYSC restart handler

Geert Uytterhoeven geert at linux-m68k.org
Thu Dec 4 04:53:52 PST 2014


Hi Arnd,

On Thu, Dec 4, 2014 at 12:47 PM, Geert Uytterhoeven
<geert at linux-m68k.org> wrote:
>> This clearly looks much better than the previous implementation, so that
>> is great. If you can decouple it from the rest of this file, either through
>> syscon or by asserting that sysc_base2 is not going to be needed for
>> anything else, how about moving the new code to a standalon driver in
>> drivers/power/reset?
>
> Yes, sysc_base2 is used for reset control only (I don't think we need to read
> the mode strap pins).
>
> So unless there's a simple solution to the regmap problem, I think moving
> this driver part to  drivers/power/reset is the most viable option.

There's another reasone for having a separate driver: if both the SH core and
the ARM core are in use, the second register bank can only be accessed after
acquiring the HPB (Peripheral Bus Bridge) semaphore.
While we don't actively support running anything on the SH core, we don't
want to prevent users from doing that.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



More information about the linux-arm-kernel mailing list