[PATCH v6 2/8] dma-mapping: replace set_arch_dma_coherent_ops with arch_setup_dma_ops
Arnd Bergmann
arnd at arndb.de
Tue Dec 2 01:16:12 PST 2014
On Monday 01 December 2014 16:58:09 Rob Herring wrote:
> > @@ -178,28 +180,21 @@ static void of_dma_configure(struct device *dev)
> > if (!dev->dma_mask)
> > dev->dma_mask = &dev->coherent_dma_mask;
> >
> > - /*
> > - * if dma-coherent property exist, call arch hook to setup
> > - * dma coherent operations.
> > - */
> > - if (of_dma_is_coherent(dev->of_node)) {
> > - set_arch_dma_coherent_ops(dev);
> > - dev_dbg(dev, "device is dma coherent\n");
> > - }
> > -
> > - /*
> > - * if dma-ranges property doesn't exist - just return else
> > - * setup the dma offset
> > - */
> > ret = of_dma_get_range(dev->of_node, &dma_addr, &paddr, &size);
> > if (ret < 0) {
> > - dev_dbg(dev, "no dma range information to setup\n");
> > - return;
> > + dma_addr = offset = 0;
> > + size = dev->coherent_dma_mask;
>
> It looks like size is not used.
Catalin has proposed a patch for handling the size right, but it's
still under discussion.
Arnd
More information about the linux-arm-kernel
mailing list