[PATCH] arm: ep93xx: add dma_masks for the M2P and M2M DMA controllers

Hartley Sweeten HartleyS at visionengravers.com
Mon Dec 1 09:16:18 PST 2014


On Friday, November 28, 2014 4:36 AM, Arnd Bergmann wrote:
> On Friday 21 November 2014, H Hartley Sweeten wrote:
>> The dma_mask and coherent_dma_mask need to be set or DMA memory allocations
>> will fail with error messages like this:
>> 
>>   ep93xx-dma ep93xx-dma-m2p: coherent DMA mask is unset
>> 
>>   ep93xx-dma ep93xx-dma-m2m: coherent DMA mask is unset
>> 
>> Add the missing information to the ep93xx-dma-m2p and ep93xx-dma-m2m
>> devices.
>> 
>> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
>> Reported-by: Jeremy Moles <cubicool at gmail.com>
>> Tested-by: Alexander Sverdlin <subaparts at yandex.ru>
>> Cc: Ryan Mallon <rmallon at gmail.com>
>
> Applied to next/fixes-non-critical. I couldn't tell from your description
> whether you want this on 3.18 or even backported to older releases,
> which I guess would make sense.
>
> If you want a backport, let me know.

Arnd,

I think the ep93xx audio got broken around this commit:

commit e27e8a60cb4ca8e3b047c5d6ee9afff9c4c5b61a
Author: Lars-Peter Clausen <lars at metafoo.de>
Date:   Sat Apr 20 19:29:05 2013 +0200

    ASoC: ep93xx: Use generic dmaengine PCM

But I'm not sure exactly where. I will try to narrow it down.

There appear to be a number of ep93xx users still out there but
they are mostly still using 2.6 kernels. It might be ok to just get
this fix in for 3.18 and then wait to see if anyone complains about
the sound not working in older kernels.

Thanks,
Hartley




More information about the linux-arm-kernel mailing list