[PATCH 1/2] pinctrl: at91: allow disabled gpio controllers

Linus Walleij linus.walleij at linaro.org
Mon Dec 1 05:56:22 PST 2014

On Fri, Nov 28, 2014 at 5:49 PM, Ludovic Desroches
<ludovic.desroches at atmel.com> wrote:

> This patch allows to have gpio controller with status set to disabled.
> gpio_banks represents all the gpio banks available on the device whereas
> nbanks represents the gpio banks used. Having a disabled gpio controller
> involves that nbanks value is lower than gpio_banks and that some
> pointers in the gpio_chips array are NULL. This patch deals with these
> specific cases.
> Signed-off-by: Ludovic Desroches <ludovic.desroches at atmel.com>

>         /* We will handle a range of GPIO pins */
> -       for (i = 0; i < info->nbanks; i++)
> -               pinctrl_add_gpio_range(info->pctl, &gpio_chips[i]->range);
> +       for (i = 0; i < gpio_banks; i++)
> +               if (gpio_chips[i])
> +                       pinctrl_add_gpio_range(info->pctl, &gpio_chips[i]->range);

I highly suspect the real solution to this problem is to get rid
of the pinctrl_add_gpio_range() call from the driver.

Remobe these calls, and instead in at91_gpio_probe() in the same
file, call gpiochip_add_pingroup_range() for each GPIO chip.

That way the GPIO ranges are inserted from the GPIO side instead
of the pinctrl side, which is way better, since it is more relative,
and make you only add ranges for the gpio chips actually there.

Linus Walleij

More information about the linux-arm-kernel mailing list