[PATCH 1/2] arm64: amd-seattle: Fix dma-ranges property
Arnd Bergmann
arnd at arndb.de
Mon Dec 1 05:33:42 PST 2014
On Sunday 30 November 2014 21:46:39 suravee.suthikulpanit at amd.com wrote:
> From: Suravee Suthikulpanit <Suravee.Suthikulpanit at amd.com>
>
> AMD Seattle should support 40-bit DMA.
>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit at amd.com>
>
The change looks good, but two things about the patch description:
- You should be a little more verbose, especially after we had discussed
this to some detail on IRC, explain why you use the specific values.
- You should configure git-send-email to know your full email address
including the name. Right now it gets sent from
"suravee.suthikulpanit at amd.com" instead of "Suravee Suthikulpanit
<Suravee.Suthikulpanit at amd.com>", and that causes the extra From
line at the start of the mail, besides looking a bit strange.
Thanks,
Arnd
More information about the linux-arm-kernel
mailing list