[PATCHv1 6/6] rtc: rtc-isl12057: add alarm support to Intersil ISL12057 RTC driver

Arnaud Ebalard arno at natisbad.org
Mon Dec 1 00:07:41 PST 2014

Hi Uwe,

Uwe Kleine-König <uwe at kleine-koenig.org> writes:

> Hello,
> finally I managed to test this series on my (unmodified) rn104.
> For patch 1: Maybe point out that the issue with the century bit isn't
> that critical, because this bit is not expected to be set before year 2100.
> For patch 3: This patch adds a few dev_err calls that get later amended
> in patch 5 to also include an error code. IMHO these should already be
> added in patch 3. Patch 5 should only add it to the already existing
> strings (if applicable).
> For patch 4: Maybe
> s/obsolete/for backwards compatibility, don't use in new code/.
> Some further comments inline ...

Thanks for the tests. I'll take a look at your comments this evening.



More information about the linux-arm-kernel mailing list