[PATCH 5/6] arm64: Port SWP/SWPB emulation support from arm

Arnd Bergmann arnd at arndb.de
Wed Aug 27 11:30:07 PDT 2014


On Wednesday 27 August 2014, Punit Agrawal wrote:
> I'll replace the counters with trace points.
> 
> There is still the pr_warn which informs the user about applications
> using legacy instructions. Hopefully, this should encourage updating the
> software.

pr_warn_ratelimit() please. There is no point printing this all the time
if nobody reads the messages.

> >> If we do both, there is no longer a need to have any debugfs file logic,
> >> which is also a plus.
> >
> > Sounds good to me.
> 
> Just a note: instead of being 'swp_emulate.enable=0' this'll be
> 'v7_obsolete.swp_emulate=0' and correspondingly for the other features.

It would be nice if the module name could be the same for arm32 and arm64,
and I don't know if we want to rename swp_emulate.c to v7_obsolete.c
on arm32.

Other than that, I have no opinion on the specific name of the module
or the option.

	Arnd



More information about the linux-arm-kernel mailing list