[PATCH v2 2/3] rc: Introduce hix5hd2 IR transmitter driver
zhangfei.gao at linaro.org
Wed Aug 27 01:49:59 PDT 2014
On 08/21/2014 06:07 PM, Sean Young wrote:
> On Thu, Aug 21, 2014 at 05:24:44PM +0800, Zhangfei Gao wrote:
>> From: Guoxiong Yan <yanguoxiong at huawei.com>
>> + rdev->driver_type = RC_DRIVER_IR_RAW;
>> + rdev->allowed_protocols = RC_BIT_ALL;
>> + rdev->priv = priv;
>> + rdev->open = hix5hd2_ir_open;
>> + rdev->close = hix5hd2_ir_close;
>> + rdev->driver_name = IR_HIX5HD2_NAME;
>> + rdev->map_name = RC_MAP_LIRC;
> I'm not sure RC_MAP_LIRC is appropriate. If the hardware has no implicit
> remote, can this be stored in device tree like the sunxi-cir.c driver does?
OK， got it.
Will set optional property "linux,rc-map-name" for the map_name.
We usually use user space lirc decoder, so this optional property may
not need to be set in dts.
>> + rdev->input_name = "Hisilicon hix5hd2 Remote Control Receiver";
> It would be useful is rdev->input_phys, rdev->input_id,
> rdev->timeout, rdev->rx_resolution are set correctly.
OK, will set rdev->timeout, rdev->rx_resolution
Not sure the usage of rdev->input_id, why is it required?
Thanks for the suggestion.
More information about the linux-arm-kernel