[PATCH 3/6] arm64: Add support for hooks to handle undefined instructions

Will Deacon will.deacon at arm.com
Tue Aug 26 11:14:06 PDT 2014


On Tue, Aug 26, 2014 at 03:56:56PM +0100, Punit Agrawal wrote:
> Will Deacon <will.deacon at arm.com> writes:
> > On Tue, Aug 26, 2014 at 11:28:47AM +0100, Punit Agrawal wrote:
> >>  asmlinkage void __exception do_undefinstr(struct pt_regs *regs)
> >>  {
> >>  	siginfo_t info;
> >> @@ -266,6 +329,9 @@ asmlinkage void __exception do_undefinstr(struct pt_regs *regs)
> >>  	if (!aarch32_break_handler(regs))
> >>  		return;
> >>  
> >> +	if (call_undef_hook(regs) == 0)
> >> +		return;
> >
> > I'd like to reuse this hook for the aarch32 break hooks (you can see the
> > direct call in the context above). That means adding support for thumb
> > after all. Is there a reason you've been avoiding that?
> 
> None, other than to not add code before it's needed. I've just had a
> quick look at break handler and it looks pretty straight forward to fold
> that change in this set. Are you OK with that?

Just do it as a separate patch on top of this one.

Will



More information about the linux-arm-kernel mailing list