[PATCH 2/9] arm64: Fix INVALID_HWID definition
mark.rutland at arm.com
Tue Aug 26 09:31:34 PDT 2014
On Fri, Aug 22, 2014 at 08:49:16PM +0100, Geoff Levand wrote:
> Change the preprocessor macro INVALID_HWID definition from ULONG_MAX to (~0)
> to allow INVALID_HWID to be used within assembly source files.
> Commit 3e98fdacc59bbbdbb659be1a144ccc48ed4860fa (arm64: kernel: make the pen of
> the secondary a 64-bit unsigned value) added the preprocessor macro INVALID_HWID
> to asm/cputype.h with it defined to be ULONG_MAX. Use of INVALID_HWID in an
> assembly source file that includes cputype.h will generate an assembler
> undefined symbol ULONG_MAX build error. The kernel does define a ULONG_MAX in
> kernel.h, but that file not setup to be included in assembly files.
We don't seem to be using INVALID_HWID in any assembly at the moment,
and I'm not sure I follow what we'd need it for.
Why do we need this in assembly?
> Signed-off-by: Geoff Levand <geoff at infradead.org>
> arch/arm64/include/asm/cputype.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> index 379d0b8..6b68380 100644
> --- a/arch/arm64/include/asm/cputype.h
> +++ b/arch/arm64/include/asm/cputype.h
> @@ -16,7 +16,7 @@
> #ifndef __ASM_CPUTYPE_H
> #define __ASM_CPUTYPE_H
> -#define INVALID_HWID ULONG_MAX
> +#define INVALID_HWID UL(~0)
> #define MPIDR_UP_BITMASK (0x1 << 30)
> #define MPIDR_MT_BITMASK (0x1 << 24)
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
More information about the linux-arm-kernel