[PATCHv4 2/2] arm64: Add CONFIG_DEBUG_SET_MODULE_RONX support
Catalin Marinas
catalin.marinas at arm.com
Tue Aug 26 07:40:23 PDT 2014
On Tue, Aug 19, 2014 at 08:41:43PM +0100, Laura Abbott wrote:
> --- /dev/null
> +++ b/arch/arm64/mm/pageattr.c
[...]
> +static int change_memory_common(unsigned long addr, int numpages,
> + pgprot_t set_mask, pgprot_t clear_mask)
> +{
> + unsigned long start = addr;
> + unsigned long size = PAGE_SIZE*numpages;
> + unsigned long end = start + size;
> + int ret;
> + struct page_change_data data;
> +
> + if (!IS_ALIGNED(addr, PAGE_SIZE)) {
> + addr &= PAGE_MASK;
> + WARN_ON_ONCE(1);
> + }
> +
> + if (!is_module_address(start) || !is_module_address(end))
> + return -EINVAL;
Minor thing, "end" is exclusive here. Do you still get the right check
with is_module_address(end)?
--
Catalin
More information about the linux-arm-kernel
mailing list