[PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly
Michal Marek
mmarek at suse.cz
Fri Aug 22 04:09:17 PDT 2014
Dne 13.8.2014 10:03, Geert Uytterhoeven napsal(a):
> CC kbuild
>
> On Wed, Aug 13, 2014 at 12:48 AM, Chen Gang <gang.chen.5i5j at gmail.com> wrote:
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index c49a775..0510a5d 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -199,6 +199,11 @@ config NEED_DMA_MAP_STATE
>> config ARCH_SUPPORTS_UPROBES
>> def_bool y
>>
>> +config CPU_LITTLE_ENDIAN
>> + depends on !CPU_BIG_ENDIAN
>> + def_bool y
>> +
>> +
>> config ARCH_HAS_DMA_SET_COHERENT_MASK
>> bool
>
> As this is a common symbol, and replicated for all affected architectures,
> I'm wondering if we should have the "config CPU_LITTLE_ENDIAN" in
> common Kconfig code instead, and make the individual architectures do a
> "select CPU_LITTLE_ENDIAN"?
Yes!
> Also we could have "config CPU_BIG_ENDIAN", too, and error out
> if none or both are selected (can Kconfig error out?).
We can error out in the Makefile, if there is consensus that we should
be doing so.
Michal
More information about the linux-arm-kernel
mailing list