[PATCH 2/2] spi: davinci: support adding delay between transmission

Mark Brown broonie at kernel.org
Thu Aug 21 11:20:35 PDT 2014

On Thu, Aug 21, 2014 at 06:25:06PM +0300, Grygorii Strashko wrote:

> +- ti,davinci-spi-wdelay : delay between transmissions.

I don't understand why this is here - there is already standard support
in the SPI core for client drivers specifying inter-transfer delays.  If
there is a need to provide platform configuration for this in addition
to that then it should also be a standard property, there is nothing
device specific about these.

> +- ti,davinci-spi-odd-parity : odd partity enabled
> +   OR
> +  ti,davinci-spi-even-parity : even parity enabled

What do these mean?

> +- ti,davinci-spi-io-type: io type (check platform_data/spi-davinci.h)

The bindings should be independent of the kernel, the values need to be
included here (and the defines moved to include/dt-bindings so they can
be used when writing DTs).

> +- ti,davinci-spi-disable-timer: disable CS timer (SPIFMTn)
> +- ti,davinci-spi-c2t-delay: c2t delay
> +- ti,davinci-spi-t2c-delay: t2c delay
> +- ti,davinci-spi-t2e-delay: t2e delay
> +- ti,davinci-spi-c2e-delay: c2e delay

What are all these timers/delays - at least some reference to the
datasheet please?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140821/09a45eb3/attachment.sig>

More information about the linux-arm-kernel mailing list