[PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton
Dmitry Torokhov
dmitry.torokhov at gmail.com
Thu Aug 21 10:05:12 PDT 2014
Hi Nishanth,
On Thu, Aug 21, 2014 at 11:02:15AM -0500, Nishanth Menon wrote:
> +
> + ret = input_register_device(input_dev);
> + if (ret) {
> + free_irq(irq, pwron);
You can not use free_irq with devm-managed resources. As I mentioned, since you
need manual unwinding, I'd rather you not use managed resources in the driver
at all.
> + cancel_delayed_work_sync(&pwron->input_work);
> + dev_dbg(dev, "Can't register power button: %d\n", ret);
> + return ret;
Thanks.
--
Dmitry
More information about the linux-arm-kernel
mailing list