[PATCH 3/5] regulator: axp20x: Update the bindings to use a local parent regulator
broonie at kernel.org
Sat Aug 16 06:58:36 PDT 2014
On Fri, Jun 06, 2014 at 06:05:52PM +0200, Maxime Ripard wrote:
> On Thu, Jun 05, 2014 at 04:49:31PM +0100, Mark Brown wrote:
> > This sounds like you are passing the MFD child device into the regulator
> > API when you should be passing the parent device in.
> We're passing the device coming from the platform_device that is
> passed in probe, that has been created by mfd_add_device, which is
> indeed the child device from the MFD device. So we should always use
> the platform device parent's instead?
> > For electrical engineering reasons it's unlikely that the supplies are
> > actually floating but yes, they are mandatory. This is an issue with
> > registering one device for the entire regulator subsystem on the PMIC,
> > it interacts somewhat poorly with deferred probe. However for systems
> > with full constraints like DT and ACPI ones it should be mostly
> > sidestepped since the if there is no supply mapped a dummy supply will
> > be substituted.
> Yes, they are actually tied to the ground, but it's still something
> meaningless, that I guess shouldn't be expressed in the DT?
Probably, that does seem like a valid case for omitting them.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: Digital signature
More information about the linux-arm-kernel