[RESEND PATCH 1/1] ARM: exynos_defconfig: Enable SBS battery support

Doug Anderson dianders at chromium.org
Mon Aug 11 08:13:45 PDT 2014


On Mon, Aug 11, 2014 at 4:06 AM, Javier Martinez Canillas
<javier.martinez at collabora.co.uk> wrote:
> Many Exynos5 boards (e.g: Snow, Peach Pit and Pi) have
> a SBS-compliant gas gauge battery. Enable it as module
> so the needed support is available for these boards.
> Suggested-by: Doug Anderson <dianders at chromium.org>
> Signed-off-by: Javier Martinez Canillas <javier.martinez at collabora.co.uk>
> Acked-by: Kukjin Kim <kgene.kim at samsung.com>
> ---
>  arch/arm/configs/exynos_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index fc7d168..c390bb9 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -77,6 +77,7 @@ CONFIG_SPI_S3C64XX=y
>  CONFIG_I2C_S3C2410=y
>  # CONFIG_HWMON is not set

I'm good with this, so:

Reviewed-by: Doug Anderson <dianders at chromium.org>

To address Bartlomiej: =m is what's in ChromeOS for exynos, though I
notice that other platforms in the ChromeOS tree have =y.  I'm not
sure why there is a difference, but it's probably just carelessness.

Normally in ChromeOS we use "=m" for drivers that can afford to wait
until after the UI is up and running.  That helps improve boot time
since the user can use the device sooner (and it's OK if the battery
driver takes a few extra seconds to load).  The only things that
really should be "=y" are drivers that are critical to load early or
that are needed for the user to interact with the system.  In this
case you could argue that loading sbs earlier means that if the system
is low on battery it will get back to "shutdown" sooner.  I'm not sure
getting the shutdown a few seconds earlier is really critical,


More information about the linux-arm-kernel mailing list