[PATCH 1/6] ARM: mvebu: Add required ethernet muxing for the Armada 370 SoC

[Ezequiel Garcia]

On 10 Aug 02:16 PM, Sebastian Hesselbarth wrote:
> On 08/08/2014 05:18 PM, Ezequiel Garcia wrote:
> > This commit adds the required pin muxing for the two network interfaces
> > and the MDIO interface, to the Armada 370 SoC.
> > 
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
> > ---
> >  arch/arm/boot/dts/armada-370.dtsi | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
> > index 21b588b..b0700bf6 100644
> > --- a/arch/arm/boot/dts/armada-370.dtsi
> > +++ b/arch/arm/boot/dts/armada-370.dtsi
> > @@ -151,6 +151,25 @@
> >  						       "mpp62", "mpp60", "mpp58";
> >  					marvell,function = "audio";
> >  				};
> > +
> > +				mdio_pins: mdio_pins {
> 
> Ezequiel,
> 
> please keep me posted next time ;)
> 

Ouch...

> Above should be: mdio_pins: mdio-pins {
> same for the ones below.
> 

OK.

> > +					marvell,pins = "mpp17", "mpp18";
> > +					marvell,function = "ge";
> 
> As we haven't used it before, we could still rename "ge" function to
> more approprate "mdio"... but it is ok.
>

FWIW, I'd rather leave it as it is. If we change the function name, we would
make backporting a PITA, just because of a nitpick.
 
> Besides the comments,
> 
> Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com>
>

Thanks,
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com