[PATCH] pinctrl: rockchip: fix rk3288 gpio0 pull up configuration

[Linus Walleij]

On Wed, Jul 30, 2014 at 5:21 AM, Sonny Rao <sonnyrao at chromium.org> wrote:

> On rk3288, for gpio bank 0, the registers which configure pull-ups
> don't implement the enable bits in the upper half of the register,
> unlike the other gpio configuration registers, and so the kernel
> must perform a read-modify-write of the register to update a
> particular gpio's pull up settings in that bank.
>
> The current code is actually clobbering the contents of the register,
> so this fixes it by using regmap_update_bits and masking out only the
> bits which require updating.  In the case of gpio0 on rk3288 the upper
> enable bits will just get ignored, and the other configurations won't
> get clobbered.
>
> Signed-off-by: Sonny Rao <sonnyrao at chromium.org>

Waiting for a v2 fixing the other issues pointed out by Heiko.

Yours,
Linus Walleij