[PATCH v2] cpufreq: arm_big_little: fix module license spec

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Thu Aug 7 23:56:30 PDT 2014

Having no license specification in a module taints the kernel during load

	arm_big_little: module license 'unspecified' taints kernel.

and also the linker doesn't allow it to make use of GPL-exported symbols
which in this case also results in errors like:

	arm_big_little: Unknown symbol cpufreq_register_driver (err 0)

. The header of the driver specifies a GPL v2 license, so note that
accordingly. While at it also add a description and an author and fix
the license in a companion file to explicit v2.

Reported-by: Andreas Schwab <schwab at suse.de>
Acked-by: Viresh Kumar <viresh.kumar at linaro.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Changes since (implicit) v1, sent with Message-Id:
1406792216-827-1-git-send-email-u.kleine-koenig at pengutronix.de:

 - Add #include <linux/module.h> to fix build failure
 - Add ack by Viresh Kumar

 drivers/cpufreq/arm_big_little.c    | 5 +++++
 drivers/cpufreq/arm_big_little_dt.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c
index 1f4d4e315057..a46c223c2506 100644
--- a/drivers/cpufreq/arm_big_little.c
+++ b/drivers/cpufreq/arm_big_little.c
@@ -24,6 +24,7 @@
 #include <linux/cpufreq.h>
 #include <linux/cpumask.h>
 #include <linux/export.h>
+#include <linux/module.h>
 #include <linux/mutex.h>
 #include <linux/of_platform.h>
 #include <linux/pm_opp.h>
@@ -593,3 +594,7 @@ void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops)
 	arm_bL_ops = NULL;
+MODULE_AUTHOR("Viresh Kumar <viresh.kumar at linaro.org>");
+MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver");
diff --git a/drivers/cpufreq/arm_big_little_dt.c b/drivers/cpufreq/arm_big_little_dt.c
index 8d9d59108906..4550f6976768 100644
--- a/drivers/cpufreq/arm_big_little_dt.c
+++ b/drivers/cpufreq/arm_big_little_dt.c
@@ -114,4 +114,4 @@ module_platform_driver(generic_bL_platdrv);
 MODULE_AUTHOR("Viresh Kumar <viresh.kumar at linaro.org>");
 MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver via DT");

More information about the linux-arm-kernel mailing list