[PATCH] cpufreq: arm_big_little: fix module license spec
Andreas Schwab
schwab at suse.de
Thu Aug 7 07:00:20 PDT 2014
Uwe Kleine-König <u.kleine-koenig at pengutronix.de> writes:
> Having no license specification in a module taints the kernel during load
> with:
>
> arm_big_little: module license 'unspecified' taints kernel.
>
> and also the linker doesn't allow it to make use of GPL-exported symbols
> which in this case also results in errors like:
>
> arm_big_little: Unknown symbol cpufreq_register_driver (err 0)
>
> . The header of the driver specifies a GPL v2 license, so note that
> accordingly. While at it also add a description and an author and fix
> the license in a companion file to explicit v2.
>
> Reported-by: Andreas Schwab <schwab at suse.de>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
> drivers/cpufreq/arm_big_little.c | 4 ++++
> drivers/cpufreq/arm_big_little_dt.c | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c
> index 1f4d4e315057..b600f3107bef 100644
> --- a/drivers/cpufreq/arm_big_little.c
> +++ b/drivers/cpufreq/arm_big_little.c
> @@ -593,3 +593,7 @@ void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops)
> arm_bL_ops = NULL;
> }
> EXPORT_SYMBOL_GPL(bL_cpufreq_unregister);
> +
> +MODULE_AUTHOR("Viresh Kumar <viresh.kumar at linaro.org>");
> +MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver");
> +MODULE_LICENSE("GPL v2");
drivers/cpufreq/arm_big_little.c:613:15: error: expected declaration specifiers or ‘...’ before string constant
MODULE_AUTHOR("Viresh Kumar <viresh.kumar at linaro.org>");
^
drivers/cpufreq/arm_big_little.c:614:20: error: expected declaration specifiers or ‘...’ before string constant
MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver");
^
drivers/cpufreq/arm_big_little.c:615:16: error: expected declaration specifiers or ‘...’ before string constant
MODULE_LICENSE("GPL v2");
^
Andreas.
--
Andreas Schwab, SUSE Labs, schwab at suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
More information about the linux-arm-kernel
mailing list