[PATCH 2/2] ARM: dts: rockchip: add bootargs setting the correct serial console

Arnd Bergmann arnd at arndb.de
Tue Aug 5 07:53:15 PDT 2014

On Tuesday 05 August 2014, Heiko Stübner wrote:
> Am Montag, 4. August 2014, 19:29:36 schrieb Arnd Bergmann:
> > On Monday 04 August 2014, Heiko Stübner wrote:
> > > Uart2 seems to be designated debug uart for all Rockchip platforms.
> > > On all rk30xx and rk31xx boards I've seen so far, this uart was used
> > > for the console and the rk3288 TRM even describes it as debug uart.
> > > 
> > > Thus add it to the core SoC dtsi files to not duplicate the same
> > > information on every board.
> > > 
> > > Signed-off-by: Heiko Stuebner <heiko at sntech.de>
> > 
> > Shouldn't this be done through the /aliases node for the port selection
> > and the current-speed property for the bit rate?
> hmm, I'm not sure I understand this ... especially how this would relate to 
> aliases.
> From reading around a bit I guess teaching the 8250_dw about 
> add_preferred_console and using "linux,stdout-path" would be the better way?

I didn't realize this was 8250_dw rather than the regular of_serial/8250
driver. Yes, it should use "linux,stdout-path". Ideally we'd do this from
common code somewhere. At the time when I wrote of_serial for PowerPC, we
didn't have to worry about UARTS that are something other than 8250, but
of course now we have plenty of different ones.


More information about the linux-arm-kernel mailing list