[PATCH] dmaengine: Remove the context argument to the prep_dma_cyclic operation

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Aug 1 10:06:33 PDT 2014

On Fri, Aug 01, 2014 at 10:14:28PM +0530, Vinod Koul wrote:
> On Fri, Aug 01, 2014 at 12:20:10PM +0200, Laurent Pinchart wrote:
> > The argument is always set to NULL and never used. Remove it.
> Thats not true.
> It was introduced in commit:
> commit 185ecb5f4fd43911c35956d4cc7d94a1da30417f
> Author: Alexandre Bounine <alexandre.bounine at idt.com>
> Date:   Thu Mar 8 15:35:13 2012 -0500
>     dmaengine: add context parameter to prep_slave_sg and prep_dma_cyclic
>     Add context parameter to device_prep_slave_sg() and device_prep_dma_cyclic()
>     interfaces to allow passing client/target specific information associated
>     with the data transfer.
>     Modify all affected DMA engine drivers.
>     Signed-off-by: Alexandre Bounine <alexandre.bounine at idt.com>
>     Acked-by: Linus Walleij <linus.walleij at linaro.org>
>     Acked-by: Felipe Balbi <balbi at ti.com>
>     Signed-off-by: Vinod Koul <vinod.koul at linux.intel.com>
> This is still used by rapidio driver. This required some extra parameters
> passed in struct rio_dma_ext.
> I do agree this is not very elegant.

Have the rapidio folk shown any sign of implementing the cyclic DMA API?
>From what I can see from drivers/rapido/, it only uses the prep_slave_sg

FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

More information about the linux-arm-kernel mailing list