[PATCH v2 1/4] rename ARCH_BCM to ARCH_BCM_MOBILE (mach-bcm)

Christian Daudt bcm at fixthebug.org
Wed Oct 30 02:22:26 EDT 2013


On Mon, Oct 28, 2013 at 1:38 PM, Olof Johansson <olof at lixom.net> wrote:
> On Mon, Sep 23, 2013 at 10:20 AM, Christian Daudt <bcm at fixthebug.org> wrote:
>> --- a/arch/arm/mach-bcm/Kconfig
>> +++ b/arch/arm/mach-bcm/Kconfig
>> @@ -1,5 +1,17 @@
>>  config ARCH_BCM
>> -       bool "Broadcom SoC" if ARCH_MULTI_V7
>> +       bool "Broadcom SoC Support"
>> +       select ARCH_MULTIPLATFORM
>
> This should be the other way around -- all other platforms seem to
> depend on ARCH_MULTIPLATFORM instead of selecting it.
>
Done
>> +       help
>> +         This enables support for Broadcom ARM based SoC
>> +          chips
>> +
>> +if ARCH_BCM
>> +
>> +menu "Broadcom SoC Selection"
>> +
>> +config ARCH_BCM_MOBILE
>> +       bool "Broadcom Mobile SoC" if ARCH_MULTI_V7
>> +       default y
>
> This shouldn't be default y, since it makes it less obvious in configs
> such as multi_v7_defconfig that the platform is enabled.
>
done.

 I've amended the existing patch with the mods above, and since they
were pretty minor, I've already folded it into a subsequent pull
request that I just sent out.

 Thanks,
   csd



More information about the linux-arm-kernel mailing list