Re: [PATCH 2/4] wl1251: move power GPIO handling into the driver

[Alexander Shiyan]

> Move the power GPIO handling from the board code into
> the driver. This is a dependency for device tree support.
> 
> Signed-off-by: Sebastian Reichel <sre at debian.org>
> ---
>  arch/arm/mach-omap2/board-omap3pandora.c     |  2 ++
>  arch/arm/mach-omap2/board-rx51-peripherals.c | 11 ++--------
>  drivers/net/wireless/ti/wl1251/sdio.c        | 21 +++++++++++++-----
>  drivers/net/wireless/ti/wl1251/spi.c         | 33 ++++++++++++++++++----------
>  drivers/net/wireless/ti/wl1251/wl1251.h      |  2 +-
>  include/linux/wl12xx.h                       |  2 +-
>  6 files changed, 43 insertions(+), 28 deletions(-)
...
> diff --git a/include/linux/wl12xx.h b/include/linux/wl12xx.h
> index b516b4f..a9c723b 100644
> --- a/include/linux/wl12xx.h
> +++ b/include/linux/wl12xx.h
> @@ -49,7 +49,7 @@ enum {
>  };
>  
>  struct wl1251_platform_data {
> -	void (*set_power)(bool enable);
> +	int power_gpio;
>  	/* SDIO only: IRQ number if WLAN_IRQ line is used, 0 for SDIO IRQs */
>  	int irq;
>  	bool use_eeprom;
> -- 

What a reason for not using regulator API here with GPIO-based regulator?

---